ci: Test against various kernels on PR #373
Conversation
|
~~ New workflow requires approval for running. ~~ I ran them on my personal fork jschwinger233#1, it looks code logic is fine but |
jschwinger233
force-pushed
the
gray/ci
branch
2 times, most recently
from
9171095 to
ddefc17
Compare
|
Alright, looks better: https://github.com/jschwinger233/dae/actions/runs/7262360947/job/19785369670?pr=1 |
|
Hey @jschwinger233, thanks for the contribution. As far as I understood, are these proposed changes mainly for |
![dae-prow[bot]](https://avatars.githubusercontent.com/in/345419?s=60&v=4){kind=small}
That's right. Although not all cases are covered (only TCP + dip filter + socks5 are tested), this workflow gives a good sense of whether dae works under different kernels. If bpf verifier complains due to complexity issues, this workflow definitely will catch them. We can also extend test suite as a follow-up if we want. |
.github/workflows/test.yml
Outdated
| push: | ||
| branches: [ main ] | ||
| pull_request: | ||
| branches: [ main ] |
There was a problem hiding this comment.
| branches: [ main ] | |
| paths: | |
| - "**/*.go" | |
| - "**/*.c" | |
| - "**/*.h" | |
| - "go.mod" | |
| - "go.sum" | |
| - ".github/workflows/test.yml" |
Add trigger conditions (based on files).
.github/workflows/test.yml
Outdated
| push: | ||
| branches: [ main ] |
There was a problem hiding this comment.
| push: | |
| branches: [ main ] |
For trouble shooting purpose, we may do the kernel-related testing in the PR level to ensure we fix the incompatible issue before we merge it to main branch.
There was a problem hiding this comment.
@jschwinger233 Thanks for the fabulous work. One little comment/suggestion from my end, would you like to rename test.yml to kernel-test.yml to clarify the purpose of the test?
jschwinger233
force-pushed
the
gray/ci
branch
from
ddefc17 to
7f7737a
Compare
|
Once again appreciate all the efforts. |
Closes: #368